Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic permissions request #1145

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Fix automatic permissions request #1145

merged 4 commits into from
Oct 3, 2023

Conversation

driedpampas
Copy link
Contributor

@driedpampas driedpampas commented Oct 2, 2023 •
edited by NotAProton
Loading

Fix(es):

  • when clicking agree on the consent page, the user will be prompted to allow "Access data for all websites". If they decline, extension will self-uninstall.
  • I made sure there are no unnecessary changes in the code;
  • Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
  • Tested on Firefox.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Download the artifacts for this pull request:

@driedpampas driedpampas force-pushed the fix-automatic-permissions-request branch from 88d397c to 6b9155b Compare October 2, 2023 13:21
@driedpampas
Copy link
Contributor Author

(does this count as hacktoberfest 😭 )

@lostdusty lostdusty added the hacktoberfest-accepted For the hacktoberfest event label Oct 2, 2023
@lostdusty
Copy link
Contributor

done?

NotAProton
NotAProton requested changes Oct 2, 2023
View reviewed changes
platform_spec/chromium/manifest.json Outdated Show resolved Hide resolved
@driedpampas
Copy link
Contributor Author

done?

not yet 😭 ran into some school work

NotAProton
NotAProton approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@NotAProton NotAProton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome and Firefox

@driedpampas
Copy link
Contributor Author

thankfully (and I rly hope firefox showed the magical permission request popup)

@driedpampas
Copy link
Contributor Author

(I'll squash when I get home)

@driedpampas driedpampas force-pushed the fix-automatic-permissions-request branch from cf90d53 to 7981d25 Compare October 3, 2023 12:32
@NotAProton NotAProton merged commit 1fd80f1 into FastForwardTeam:main Oct 3, 2023
4 checks passed
@driedpampas driedpampas deleted the fix-automatic-permissions-request branch October 4, 2023 15:56
@driedpampas driedpampas restored the fix-automatic-permissions-request branch October 4, 2023 15:56
@driedpampas driedpampas deleted the fix-automatic-permissions-request branch October 4, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAProton NotAProton NotAProton approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted For the hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driedpampas @lostdusty @NotAProton